[full-ci][tests-only] test: convert admin-settings-spaces.feature to playwright#13488
Merged
anon-pradip merged 6 commits intomasterfrom Mar 23, 2026
Merged
Conversation
425b360 to
af00be4
Compare
70 tasks
4af8285 to
358c812
Compare
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
nabim777
reviewed
Jan 28, 2026
d191a61 to
5bd42ac
Compare
27fe444 to
b918140
Compare
b918140 to
4e072ac
Compare
59185c1 to
78736b3
Compare
78736b3 to
cdfe711
Compare
cdfe711 to
5b2fa88
Compare
77463f1 to
5b2fa88
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
convert spaces.feature test to playwright test
Regarding the use of
shared.tsProblem
Playwright e2e tests failed when keycloak was enabled in CI with error:
TypeError: Cannot read properties of undefined (reading 'newContext')
The root cause was twofold:
keycloak/user.tsimportedstatefromcucumber/environment/shared, but playwright had its owne2e-playwright/support/shared.ts- different modules with different browser instancesglobalBeforeHookusedapi.token.setAccessAndRefreshTokenwhich performs oCIS auth flow, incompatible with keycloakSolution
Deleted
e2e-playwright/support/shared.tsUpdated
e2e-playwright/support/test.tsande2e-playwright/support/world.tsto import state fromcucumber/environment/shared- the single shared state used by both frameworksAdded keycloak token setup in
globalBeforeHook(matching cucumber's Before hook):api.keycloak.setAccessTokenForKeycloakOcisUser(user)api.keycloak.setAccessTokenForKeycloakUser(user)storeKeycloakGroups(user, usersEnvironment)Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: